Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backports: f535d2e (#6586, PR #6593) #6595

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Backports: f535d2e (#6586, PR #6593) #6595

merged 3 commits into from
Sep 25, 2024

Conversation

dsotirho-ucsc
Copy link
Contributor

@dsotirho-ucsc dsotirho-ucsc commented Sep 24, 2024 •
edited
Loading

Checklist

Author

  • Target branch is develop
  • Name of PR branch matches backports/<7-digit SHA1 of most recent backported commit>
  • PR title contains the 7-digit SHA1 of the backported commits
  • PR title references the issues relating to the backported commits
  • PR title references the PRs that introduced the backported commits

Author (before every review)

  • Merged develop into PR branch to integrate upstream changes
  • Ran make requirements_update or this PR does not modify requirements*.txt, common.mk, Makefile and Dockerfile
  • Added R tag to commit title or this PR does not modify requirements*.txt
  • This PR is labeled reqs or does not modify requirements*.txt

System administrator (after approval)

  • Actually approved the PR
  • Decided if PR can be labeled no sandbox
  • PR title is appropriate as title of merge commit
  • Moved connected issue to Approved column
  • PR is assigned to only the operator

Operator (before pushing merge the commit)

  • Sanity-checked history
  • Pushed PR branch to GitHub
  • Added sandbox label or PR is labeled no sandbox
  • Pushed PR branch to GitLab dev or PR is labeled no sandbox
  • Pushed PR branch to GitLab anvildev or PR is labeled no sandbox
  • Build passes in sandbox deployment or PR is labeled no sandbox
  • Build passes in anvilbox deployment or PR is labeled no sandbox
  • Reviewed build logs for anomalies in sandbox deployment or PR is labeled no sandbox
  • Reviewed build logs for anomalies in anvilbox deployment or PR is labeled no sandbox
  • The title of the merge commit starts with the title of this PR
  • Added PR # reference (to this PR) to merge commit title
  • Collected commit title tags in merge commit title but excluded any p tags
  • Pushed merge commit to GitHub

Operator (after pushing the merge commit)

  • Pushed merge commit to GitLab dev
  • Pushed merge commit to GitLab anvildev
  • Build passes on GitLab dev
  • Reviewed build logs for anomalies on GitLab dev
  • Build passes on GitLab anvildev
  • Reviewed build logs for anomalies on GitLab anvildev
  • Deleted PR branch from GitHub
  • Deleted PR branch from GitLab dev
  • Deleted PR branch from GitLab anvildev

Operator

  • PR is assigned to no one

Shorthand for review comments

  • L line is too long
  • W line wrapping is wrong
  • Q bad quotes
  • F other formatting problem

@github-actions github-actions bot added the orange [process] Done by the Azul team label Sep 24, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.38%. Comparing base (e8c2280) to head (2c9e80e).
Report is 4 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #6595   +/-   ##
========================================
  Coverage    85.38%   85.38%           
========================================
  Files          155      155           
  Lines        20754    20754           
========================================
  Hits         17720    17720           
  Misses        3034     3034
Flag Coverage Δ
85.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Coverage Status

coverage: 85.398%. remained the same
when pulling 2c9e80e on backports/f535d2e
into e8c2280 on develop.

@dsotirho-ucsc dsotirho-ucsc mentioned this pull request Sep 24, 2024
Merged
40 tasks
@hannes-ucsc hannes-ucsc added the no sandbox [process] PR will not be tested in the sandbox label Sep 25, 2024
@hannes-ucsc hannes-ucsc merged commit 33796d4 into develop Sep 25, 2024
9 checks passed
@hannes-ucsc hannes-ucsc deleted the backports/f535d2e branch September 25, 2024 02:12
@dsotirho-ucsc dsotirho-ucsc removed their assignment Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hannes-ucsc hannes-ucsc hannes-ucsc approved these changes

Assignees
No one assigned
Labels
no sandbox [process] PR will not be tested in the sandbox orange [process] Done by the Azul team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsotirho-ucsc @coveralls @hannes-ucsc